Spaghetti. More suitable for my plate than an app.
I know that Java is a terribly verbose language, but even for Java this looks over the top.
This code is written with a bulldozer !
How hard is it to refactor each of those branches into separate functions or objects ?
If there's no time for that, I wonder, is there enough time to figure out the security and privacy implications
of this entire codebase ?
Should I trust this code with my life ? Because some people will ...
I don't think Telegram is something people who need security should be using, but this kind of stylistic shaming toward open-source projects is useless at best and harmful in most cases.
Maybe I'm wrong, but last time I checked, Telegram is not entirely "open source". The core part of the service is secret.
Which kind of voids the whole 'open source' argument and actually makes this whole project doubly sneaky..
Also, open source does not automatically imply high quality or immunity from criticism.
In this particular case, when people can be arrested or even executed for what they say (in some countries), this kind of code can be plain dangerous.
Even if their intentions are absolutely pristine and they really want to do good in the world (which I hope they are) - a bit more diligence about the quality of the stuff you're sharing never hurts.
In what way is it constructive to suggest that stylistic problems with somebody's code indicate that the program is unfit for use?
It seems to me about as constructive as walking into any software company and saying, "Ugh, these engineers are wearing t-shirts and their shoes are completely unshined! People, if these programmers care so little for their appearance, can you trust them to care about their code?"
I don't think you are getting the point. It is not just a stylistic issue! The code is hard to understand and reason about because it is written like a book.
