Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Small nit: I believe this is incorrect:

> More recently, all Git-based deployments (which is to say, virtually all deployments) to Heroku were blocked and review apps were halted for all users as a result of a GitHub OAuth token leak.

It should read "all GitHub-based deployments". You can still deploy with `git push heroku main`.



Ah yup good catch - just updated the article


It caught my eye too, but for a different reason, this bit doesn't seem right:

> which is to say, virtually all deployments

My understanding is if deploying with `git push heroku main`, that application's GitHub repository was not viewable by hackers (but those apps deployed through 'Heroku GitHub Deploys' were). (please tell me if my understanding is incorrect).

I think most Heroku users would deploy with `git push heroku main`, although that's purely hunch.

Unrelated, but I'd add one more thing to the article, which is that Heroku docs aren't easy to give feedback on. I'd love for the docs to be on GitHub so shortcomings or inaccuracies can quickly be addressed. Currently, to point out a correction to the docs, you'd have to write a support ticket and 100% chance that support ticket isn't going beyond the person who received it, so nothing will get actioned.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: