>> The C version is functional but will probably make more experienced C...

VMG · on June 2, 2012

Not being a experienced C programmer by any measure, but this doesn't look right to me: https://github.com/thraxil/boggle/blob/master/boggle.c#L92

    struct foo f() {
        struct foo f;
        return f;
    }

isn't returning a stack-allocated struct a bad idea?

tosseraccount · on June 2, 2012

It returns a copy of it. Example:

#include <stdio.h>

struct foo { char space[1024]; };

struct foo f()

{

    struct foo f;

    printf("address of f is %p\n",&f);

    return f;

}

int main()

{

    struct foo g;

    g = f();

    printf("address of g is %p\n",&g);

    return 0;

}

produces this output:

address of f is 0x7fbfffec30

address of g is 0x7fbffff050

Jare · on June 3, 2012

If I remember correctly (been a long time), most compilers would implement many cases of struct return by letting the caller pass the address of a block of (stack) memory to contain the return value. The function can then optimize things to get rid of its local copy, operate directly on the intended target, and the caller doesn't need to perform any copies.

VMG · on June 3, 2012

Thanks, I didn't know that.